Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptiPlex 7010/9010 v0.1.0 #541

Merged
merged 13 commits into from
Sep 5, 2024
Merged

OptiPlex 7010/9010 v0.1.0 #541

merged 13 commits into from
Sep 5, 2024

Conversation

filipleple
Copy link
Member

No description provided.

@filipleple filipleple self-assigned this Jul 25, 2024
@pietrushnic
Copy link
Contributor

@filipleple, it would be great if those commit names and descriptions were improved to the upstream quality. Some effort should be upstream first or dasharo-pq (intentional trolling).

@filipleple
Copy link
Member Author

@pietrushnic yes of course, I was going to edit the commits into a more informative and formal character as soon as I obtain a satisfying binary and make sure each of them is correct and necessary.

@filipleple filipleple force-pushed the optiplex-revival branch 7 times, most recently from 38317b2 to 467ad38 Compare July 29, 2024 12:50
@filipleple filipleple changed the title optiplex release prep work OptiPlex 7010/9010 v0.1.0 Jul 29, 2024
@filipleple filipleple marked this pull request as ready for review July 29, 2024 12:55
@filipleple filipleple force-pushed the optiplex-revival branch 2 times, most recently from ca99e49 to 42719d5 Compare July 30, 2024 10:05
build.sh Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi_txt Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi_txt Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi_txt Outdated Show resolved Hide resolved
configs/config.dell_optiplex_9010_sff_uefi_txt Outdated Show resolved Hide resolved
src/mainboard/dell/snb_ivb_workstations/default.fmd Outdated Show resolved Hide resolved
src/security/intel/txt/common.c Show resolved Hide resolved
Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the build to the GitHub workflows too

@filipleple filipleple force-pushed the optiplex-revival branch 2 times, most recently from 4089b90 to f48831d Compare July 30, 2024 15:40
@filipleple
Copy link
Member Author

@miczyg1 added OptiPlex 9010 to build CI in this commit

Copy link
Contributor

@miczyg1 miczyg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't plan to release anything else other than UEFI and TXT enabled config, so for better readability of the binary artifact these changes should be better

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@miczyg1
Copy link
Contributor

miczyg1 commented Sep 5, 2024

Had to rebase, because it didn't merge cleanly with FF method. Will wait for the CI to pass first.

@miczyg1
Copy link
Contributor

miczyg1 commented Sep 5, 2024

Optiplex builds, but other boards fail, probably bad EDK2 revision. Merging anyway them

@miczyg1 miczyg1 merged commit 9bfb510 into dasharo Sep 5, 2024
13 of 35 checks passed
@miczyg1 miczyg1 deleted the optiplex-revival branch September 5, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants